Skip to content

[Master]-]Withholding Tax Entries are not generated at payment because the Withholding Tax. Prod. Posting Group field gets not transferred to the payment line#9479

Merged
neeleshsinghal merged 7 commits into
mainfrom
bugs/Bug-639524-WHT-Prod-Posting-Group-not-transferred-to-payment1
Jul 17, 2026
Merged

[Master]-]Withholding Tax Entries are not generated at payment because the Withholding Tax. Prod. Posting Group field gets not transferred to the payment line#9479
neeleshsinghal merged 7 commits into
mainfrom
bugs/Bug-639524-WHT-Prod-Posting-Group-not-transferred-to-payment1

Conversation

@neeleshsinghal

@neeleshsinghal neeleshsinghal commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

@neeleshsinghal
neeleshsinghal requested a review from a team July 15, 2026 11:21
@github-actions github-actions Bot added the AL: Apps (W1) Add-on apps for W1 label Jul 15, 2026
@github-actions github-actions Bot added this to the Version 29.0 milestone Jul 15, 2026
@microsoft microsoft deleted a comment from github-actions Bot Jul 15, 2026
Comment thread src/Apps/W1/WithholdingTax/Test/src/ERMWithholdingTaxTestsII.Codeunit.al Outdated
@github-actions

github-actions Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Copilot PR Review

Iteration 2 · Outcome: completed

Knowledge source: https://github.com/microsoft/BCQuality@186d8a131465475c79244d994acb872cd5c0d4bf

Findings by domain

Findings split into Knowledge-backed (cite a BCQuality article) and Agent (the agent's own judgement, no matching BCQuality rule).

Domain Findings Knowledge-backed Agent Inline Fallback
Testing 1 0 1 1 0

Totals: 0 knowledge-backed · 1 agent findings.

Orchestrator pre-filter (2 file(s) excluded)

  • layer-disabled (knowledge) : 2 file(s)

Findings produced by the AL review agent v1.7.3. Reply 👎 on any inline comment to flag false positives.

@neeleshsinghal neeleshsinghal added the Finance GitHub request for Finance area label Jul 16, 2026
@neeleshsinghal
neeleshsinghal requested a review from Copilot July 17, 2026 02:48

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses missing Withholding Tax (WHT) posting behavior when creating vendor payments by ensuring the Withholding Tax Product Posting Group is transferred onto the generated payment journal line (Create Payment flow), so WHT entries can be generated correctly at payment posting.

Changes:

  • Subscribes to Create Payment to copy "Wthldg. Tax Prod. Post. Group" onto the payment Gen. Journal Line based on the applied invoice’s WHT entry.
  • Adds a new test intended to validate WHT product posting group propagation (currently focused on invoice-posting/WHT-entry behavior).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
src/Apps/W1/WithholdingTax/Test/src/ERMWithholdingTaxTestsII.Codeunit.al Adds a new test and label related to WHT product posting group propagation.
src/Apps/W1/WithholdingTax/app/src/Purchase/Transaction/WithholdingTaxJnlSubscriber.Codeunit.al Adds Create Payment event subscriber to populate WHT product posting group on generated payment journal lines.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@neeleshsinghal
neeleshsinghal requested review from a team and AndersLarsenMicrosoft July 17, 2026 04:58
@neeleshsinghal
neeleshsinghal enabled auto-merge July 17, 2026 07:27
@neeleshsinghal
neeleshsinghal added this pull request to the merge queue Jul 17, 2026
Merged via the queue into main with commit 1b6bada Jul 17, 2026
328 of 331 checks passed
@neeleshsinghal
neeleshsinghal deleted the bugs/Bug-639524-WHT-Prod-Posting-Group-not-transferred-to-payment1 branch July 17, 2026 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AL: Apps (W1) Add-on apps for W1 Finance GitHub request for Finance area

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants